MySQL wont update db data with php

Question

I cant see the problem in my update form, but no matter what i do it will not update my db. I was hoping someone in here could help me out.

I have tried to use mysql_error() after the update statement but no errors was found and have tried echoing out the update statement and couldn't see any problems.

URL = http://localhost/maga/php/update_red.php?id=6&read=14

<?php
$host="localhost";
$pass="*****";
$user="my_db_user";
$db="my_db_name";
$tblname="artikler";

$con=mysql_connect($host, $user, $pass)or die(mysql_error());
mysql_select_db($db)or die(mysql_error());

$read=(int)$_GET['read'];
$id=$_GET['id'];

$read++;

mysql_query("UPDATE $tblname SET read='$read' WHERE id='$id'");

?>

Probably is, but it's localhost, we don't know his IP so it's fine. — DanRedux
– DanRedux, Commented Mar 12, 2012 at 17:58
Your script is vulnerable to SQL injection by not cleansing your $id variable. — Jeff Hines
– Jeff Hines, Commented Mar 12, 2012 at 17:59

Paul Dixon · Accepted Answer · 2012-03-12 18:20:49Z

2

read is a reserved word, and so needs to be specially quoted with backticks for it to work in query

so try

if (!mysql_query("UPDATE $tblname SET `read`='$read' WHERE id='$id'"))
{
    die("update failed with error ".mysql_error());
}

Also, the $id value isn't being sanitized in any way, so the code is vulnerable to an SQL injection attack. Definitely worth your time learning about such things.

answered Mar 12, 2012 at 18:20

Paul Dixon

302k54 gold badges315 silver badges349 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DanRedux · Accepted Answer · 2012-03-12 17:58:14Z

0

Try outputting your query:

print("UPDATE $tblname SET read='$read' WHERE id='$id'");

Also, is your ID field a number? If so, get rid of the quotes you have around it.

answered Mar 12, 2012 at 17:58

DanRedux

9,3996 gold badges25 silver badges41 bronze badges

Comments

Ravish · Accepted Answer · 2012-03-12 18:15:07Z

0

do a very simple thing, echo "UPDATE $tblname SET read='$read' WHERE id='$id'";
Try running the query from phpmyadmin or whatever tool you use for writing mysql queries.

See if it gives you any error...

answered Mar 12, 2012 at 18:15

Ravish

2,4194 gold badges38 silver badges58 bronze badges

1 Comment

thegingerdk Over a year ago

found the problem, i think 'read' is an sql value because when i change the name of the column i had no problems in updating it. but thanks for the great advises...

Ishmael · Accepted Answer · 2012-03-12 18:15:17Z

0

You're not passing the database connection on your mysql_query:

mysql_query("UPDATE $tblname SET read='".$read."' WHERE id='".$id."'", $con);

answered Mar 12, 2012 at 18:15

Ishmael

1212 silver badges14 bronze badges

1 Comment

fred2 Over a year ago

You don't have to with mysql_query.

Pedro Teran · Accepted Answer · 2012-03-12 18:22:42Z

0

Try this code:

<?php
$host="localhost";
$pass="*****";
$user="my_db_user";
$db="my_db_name";
$tblname="artikler";

mysql_connect($host, $user, $pass)or die(mysql_error());
mysql_select_db($db)or die(mysql_error());

$read=(int)$_GET['read'];
$id=$_GET['id'];

$read++;

mysql_query("UPDATE $tblname SET read='$read' WHERE id='$id'");

mysql_close();

?>

answered Mar 12, 2012 at 18:22

Pedro Teran

1,2003 gold badges18 silver badges43 bronze badges

Comments

Venkat Selvan · Accepted Answer · 2012-03-12 19:11:13Z

0

Try this

\\In your script add the below line and try whether its working
$con=mysql_connect($host, $user, $pass)or die(mysql_error());
mysql_select_db($db,$con)or die(mysql_error());

answered Mar 12, 2012 at 19:11

Venkat Selvan

3,1261 gold badge17 silver badges12 bronze badges

Comments

thegingerdk · Accepted Answer · 2012-03-13 08:45:22Z

0

found the problem, i think 'read' is an sql value because when i changed the name of the column i had no problems in updating it... but thanks for all the good advises...

answered Mar 13, 2012 at 8:45

thegingerdk

1911 gold badge1 silver badge7 bronze badges

1 Comment

Paul Dixon Over a year ago

that's the answer I gave you yesterday :)

Collectives™ on Stack Overflow

MySQL wont update db data with php

7 Answers 7

Comments

Comments

1 Comment

1 Comment

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

1 Comment

1 Comment

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related