Calling a function from within another function in PHP, but get error Using $this when not in object context

Question

I have the code below: from the getData function im trying to call get_xml within the same class, but I get the error Using $this when not in object context . I have been programming quite some time, so maybe my brains shut off, but imho this should work right? What am I missing here?

class modDataHelper {

    function getData($rid) {
        $xml = $this->get_xml('http://www.dataserver.nl/rss/feed.php?id=' . $rid, 60000);

        return $xml;
    }

    function get_xml($url, $max_age) {
        $file = 'cache/' . md5($url);

        if (file_exists($file)
                && filemtime($file) >= time() - $max_age) {
            // the cache file exists and is fresh enough
            return simplexml_load_file($file);
        }

        $xml = file_get_contents($url);
        file_put_contents($file, $xml);
        return simplexml_load_string($xml);
    }

}

In another file I call

$data = modDataHelper::getData(19464);

fixed it by calling $xml = self::get_xml('http://www.dataserver.nl/rss/feed.php?id=' . $rid, 60000); Thanks guys for helping me understand AND give me the answer! — Hans Wassink
– Hans Wassink, Commented Mar 22, 2012 at 10:47
Its calling statically using scope resolution operator "::" rather than "->" and self keyword stands for "calling classes own function hence 'self'" — OM The Eternity
– OM The Eternity, Commented Mar 22, 2012 at 10:52
Not for the points, but i think the Q&A could use some upvotes, because google is not really spitting out clear answers, at least not as clear as yours! — Hans Wassink
– Hans Wassink, Commented Mar 22, 2012 at 10:56

Community · Accepted Answer · 2017-05-23 10:08:37Z

4

You are calling a static method by using ::.

There is no $this in static context use self.

When to use self over $this?

class modDataHelper {

    static function getData($rid) {
        $xml = self::get_xml('http://www.dataserver.nl/rss/feed.php?id=' . $rid, 60000);

        return $xml;
    }

    static function get_xml($url, $max_age) {
        $file = 'cache/' . md5($url);

        if (file_exists($file)
                && filemtime($file) >= time() - $max_age) {
            // the cache file exists and is fresh enough
            return simplexml_load_file($file);
        }

        $xml = file_get_contents($url);
        file_put_contents($file, $xml);
        return simplexml_load_string($xml);
    }

}

edited May 23, 2017 at 10:08

CommunityBot

11 silver badge

answered Mar 22, 2012 at 10:42

jantimon

38.5k23 gold badges127 silver badges195 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

GordonM Over a year ago

I didn't think PHP even allowed calling a non-static method statically anymore without at the very least throwing a warning.

Envyrus · Accepted Answer · 2012-03-22 10:46:02Z

1

You are calling getData statically, i.e. there is no object instance, no this.

You need to do something like:

$data = new modDataHelper();
$data->getData(10464)

Or if you want to use static methods you need to declare them as "static" and use "self::", instead of "$this->".

For more info see here.

answered Mar 22, 2012 at 10:46

Envyrus

3151 gold badge3 silver badges10 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 10:34:36Z

1

Use Ghommey's solution or...

$mdh = new modDataHelper;
$data = $mdh->getData(19464);

Also take a look of this

edited May 23, 2017 at 10:34

CommunityBot

11 silver badge

answered Mar 22, 2012 at 10:45

Wh1T3h4Ck5

8,52910 gold badges63 silver badges82 bronze badges

4 Comments

Hans Wassink Over a year ago

I thought of this, but that kinda felt dirty from inside a function of the same class...

Wh1T3h4Ck5 Over a year ago

From inside function of the same class, you can use $data = $this->getData(19464); where $this refers to current object and getData() to object's method.

Hans Wassink Over a year ago

Ah, I see what you mean now, you refered to my last line of code, not to the getData func. Tata

Wh1T3h4Ck5 Over a year ago

In fact, $xml = $this->get_xml(... is OK but in this case you can't call getData method as static, using (::) operator.

Collectives™ on Stack Overflow

Calling a function from within another function in PHP, but get error Using $this when not in object context

3 Answers 3

1 Comment

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related