Why can't I make a proper SQL/PHP query using javascript?

Question

I am trying to make a query to an SQL database and I can't figure out why my code won't work. When I call the javascript function:

function calledfunction(){
var date = new Date(document.getElementById("datetime1").value);
var dateformat = "'"+date.getFullYear() + "-" + (date.getMonth()+1) + "-" + date.getDate() + " " + date.getHours() +":" + date.getMinutes()+"'";
        alert("Value is: " + dateformat);
                microAjax("genjsonphp.php?stdt="+dateformat, function(data) {
                     //edited out
      }

I get the alert: Value is: '2011-12-6 0:0'

When I copy the value in the alert and paste it so the above code becomes:

function calledfunction(){
var date = new Date(document.getElementById("datetime1").value);
var dateformat = "'"+date.getFullYear() + "-" + (date.getMonth()+1) + "-" + date.getDate() + " " + date.getHours() +":" + date.getMinutes()+"'";
        alert("Value is: " + dateformat);
dateformat = '2011-12-6 0:0';

                microAjax("genjsonphp.php?stdt="+dateformat, function(data) {
                     //edited out
      }

Then the code works fine. Does anyone have an idea what is going wrong?

As a side note, I think you should make your query string more URL "formatty". It might mess up your ajax otherwise microAjax("genjsonphp.php?stdt="+encodeURIComponent(dateformat), function(){}); — ShadowScripter
– ShadowScripter, Commented Apr 3, 2012 at 16:41

cHao · Accepted Answer · 2012-04-03 17:58:09Z

4

You're explicitly quoting the variable string:

 "'"+date.getFullYear() ...

so you're sending

genjsonphp.php?stdt='2011-12-6 0:0'

(note the single quotes)

In the second case you're sending:

genjsonphp.php?stdt=2011-12-6 0:0

edited Apr 3, 2012 at 17:58

cHao

87k21 gold badges147 silver badges178 bronze badges

answered Apr 3, 2012 at 16:38

Alex K.

177k32 gold badges276 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

encodes Over a year ago

console.log the url's and you will see that Alex K. is correct.

Stagleton Over a year ago

so, var dateformat = '2011-12-6 0:0'; and var dateformat = "'"+date.getFullYear() + "-" + (date.getMonth()+1) + "-" + date.getDate() + " " + date.getHours() +":" + date.getMinutes()+"'"; do not produce the same thing?

Alex K. Over a year ago

Nope; var X = 'A' is the 1 character string A whereas var X = "'" + 'A' + "'" is the 3 character long string 'A'

stUrb · Accepted Answer · 2012-04-03 16:40:13Z

1

this "genjsonphp.php?stdt="+'2011-12-6 0:0' parses to: "genjsonphp.php?stdt=2011-12-6 0:0" while "genjsonphp.php?stdt="+dateformat parses to: "genjsonphp.php?stdt='2011-12-6 0:0'"

Watch the quotes.

answered Apr 3, 2012 at 16:40

stUrb

6,8708 gold badges45 silver badges74 bronze badges

Collectives™ on Stack Overflow

Why can't I make a proper SQL/PHP query using javascript?

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related