Update model_testing.py #10588
Open
Update model_testing.py #10588
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
suggested changes
Jan 3, 2022
wochinge
reviewed
Jan 5, 2022
|
|
||
| rasa.shared.utils.io.create_directory(output_directory) | ||
|
|
||
| if not additional_arguments: |
Contributor
There was a problem hiding this comment.
can we please also add a test to avoid regression?
Contributor
Author
There was a problem hiding this comment.
While writing the test I realized something else.
I'm pretty sure that the model and nlu_data parameters aren't optional as-is either. Can I remove the Optional type here?
Contributor
There was a problem hiding this comment.
good catch 👍🏻 Yeah, but please check the usages of this function then
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
m-vdb
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10587.