This repository was archived by the owner on Nov 30, 2018. It is now read-only.
remove namespace and improve style #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2014 11:22
it really is default, just no specs are run. risky, but no wifi on flight
Author
|
sorry the last commit does more than just namespace, but breaking it up is something I just don't have time for right now :/ |
Contributor
|
Awesome commit, thanks for the work! |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Author
|
My pleasure! |
aesnyder
pushed a commit
that referenced
this pull request
Nov 12, 2014
remove namespace and improve style
Contributor
|
It occurred to me that one of the goals of this change was to stop modifying the prototype of String, but I think we still have that code in there, unless I just missed it in the diff. |
Author
|
Yeah I've just been hitting it in waves - eventually we will eradicate it all |
Contributor
|
Gotcha, you're on it. Just thought I would mention it. Thanks again! |
Author
|
:) no problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.