This repository was archived by the owner on Apr 17, 2025. It is now read-only.
fix(fetch): Replaced php short tag with <?php in fetch latest script. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast CGI running on Nginx does not support short tags by default, and this is typically not a setting that can be set at runtime. It's simpler to remove the requirement in code rather than force every environment's php config to support short_tags.
|
Looks good to me. |
Contributor
|
LGTM |
jeffbcross
added a commit
that referenced
this pull request
Jun 4, 2013
fix(fetch): Replaced php short tag with <?php in fetch latest script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast CGI running on Nginx does not support short tags by default, and this is typically not a setting that can be set at runtime. It's simpler to remove the requirement in code rather than force every environment's php config to support short_tags.