feat: install udev rules for UNO Q #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
approved these changes
Nov 18, 2025
per1234
suggested changes
Nov 18, 2025
| if [ "$EUID" -ne 0 ]; then | ||
| if [ -e "${PWD}/post_install.sh" ]; then | ||
| if command -v pkexec > /dev/null 2>&1; then | ||
| echo "Requesting root privileges via $PKEXEC..." |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "Requesting root privileges via $PKEXEC..." | |
| echo "Requesting root privileges..." |
The PKEXEC variable is not defined by the script, and at least on my Ubuntu machine, not defined globally. So the previous command would output:
Requesting root privileges via ...
I don't see any need to surface to the user the exact tool that is being used to request the privileges, so I think the best approach is to reword it as in my suggestion above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a post-installation script for adding udev rules for UNO Q