loader: export symbols for Arduino_JSON library #266
Conversation
|
|
|
Hi @hajimef , thanks for the contribution! I'd move |
facchinm
left a comment
There was a problem hiding this comment.
As per comment, plus need to fix the commit message before merging
hajimef
left a comment
There was a problem hiding this comment.
Thank you for comment.
I moved the line as you suggested.
I then tried the Adafruit NeoPixel library and found that I also needed to add strtol, so I added that line as well.
5630ffb to
dbb4842
Compare
dbb4842 to
a93b329
Compare
libc shouldn't be linked in dynamic build, while it's needed when the validation step is executed. Validated against the previous patch, nigthly arduino-cli and ~/Arduino/libraries/Arduino_JSON/examples/JSONArray/ example
| build.link_command="{compiler.path}{compiler.c.elf.cmd}" "-L{build.path}" "-L{build.variant.path}" {compiler.c.elf.flags} {compiler.c.elf.extra_flags} {build.extra_flags} {build.extra_ldflags} {compiler.zephyr.common_ldflags} --specs=picolibc.specs --specs=nosys.specs {compiler.ldflags} {object_files} -Wl,--start-group "{build.path}/{archive_file}" {compiler.zephyr.extra_ldflags} {compiler.libraries.ldflags} -Wl,--end-group {build.link_args.{build.link_mode}} | ||
|
|
||
| build.check_command-dynamic={build.link_command} {build.link_args.check-dynamic} -o "{build.path}/{build.project_name}_check.tmp" | ||
| build.check_command-dynamic={build.link_command} -lc -lm -lgcc {build.link_args.check-dynamic} -o "{build.path}/{build.project_name}_check.tmp" |
There was a problem hiding this comment.
Those added libraries are not used in the final link stage, so this change masks actual build errors AFAICS. What am I missing?
There was a problem hiding this comment.
I built it with the 0.51.0 tag.
And the target was arduino_uno_q.
This may be the cause.
When running the Arduino_JSON library (https://github.com/arduino-libraries/Arduino_JSON), I encountered the error "llext: Undefined symbol with no entry in symbol table."
So I added the necessary symbols.