Skip to content

fix: handler HEAD calls in sse routes #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+27 −3
Open

fix: handler HEAD calls in sse routes #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
022f1c1
fix: handler HEAD calls in sse routes
lucarin91 Nov 20, 2025
5c25409
fix typo
lucarin91 Nov 21, 2025
0f9969c
make hotfix instead
lucarin91 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/api/handlers/app_logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ func HandleAppLogs(
Follow: follow,
}

// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
}

sseStream, err := render.NewSSEStream(r.Context(), w)
if err != nil {
slog.Error("Unable to create SSE stream", slog.String("error", err.Error()))
Expand Down
6 changes: 6 additions & 0 deletions internal/api/handlers/app_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ func HandlerAppStatus(
cfg config.Configuration,
) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
}

sseStream, err := render.NewSSEStream(r.Context(), w)
if err != nil {
slog.Error("Unable to create SSE stream", slog.String("error", err.Error()))
Expand Down
11 changes: 8 additions & 3 deletions internal/api/handlers/system_resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,21 @@ import (

func HandleSystemResources() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
sseStream, err := render.NewSSEStream(ctx, w)
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
}

sseStream, err := render.NewSSEStream(r.Context(), w)
if err != nil {
slog.Error("Unable to create SSE stream", slog.String("error", err.Error()))
render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to create SSE stream"})
return
}
defer sseStream.Close()

resources, err := orchestrator.SystemResources(ctx, nil)
resources, err := orchestrator.SystemResources(r.Context(), nil)
if err != nil {
sseStream.SendError(render.SSEErrorData{
Code: render.InternalServiceErr,
Expand Down
7 changes: 7 additions & 0 deletions internal/api/handlers/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@ func HandleUpdateApply(updater *update.Manager) http.HandlerFunc {

func HandleUpdateEvents(updater *update.Manager) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
// HOTFIX: app-lab use HEAD requests to check endpoint availability
// so we need to handle them here by early return without opening SSE stream
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
}

sseStream, err := render.NewSSEStream(r.Context(), w)
if err != nil {
slog.Error("Unable to create SSE stream", slog.String("error", err.Error()))
Expand Down