🤖 fix: fail-fast workspace title generation with provider errors #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Revert fallback chat-{timestamp} behavior
- generateWorkspaceName now throws SendMessageError-compatible objects
- IpcMain maps errors to Result<void, SendMessageError> so UI shows provider toasts
_Generated with `mux`_
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Return Result from title generator (no throws) - Update IPC call sites and logs - Apply Prettier _Generated with _
6708973 to
c8a6ff4
Compare
- Keep fail-fast for missing/invalid config
- Use temporary chat-{timestamp} for providers without title support
- Clean up comments
_Generated with _
2536969 to
5b0cc17
Compare
…itle when provider lacks title support
- Creation flow now uses ChatInputToast + createErrorToast for SendMessageError, matching workspace UX
- Title generator no longer blocks on missing API key for non-Anthropic/OpenAI providers; uses chat-{timestamp} fallback instead
_Generated with `mux`_
113995a to
c72415f
Compare
- Creation ChatInput no longer wipes the input when workspace creation fails - useCreationWorkspace.handleSend now returns boolean success so UI can decide when to clear _Generated with _
…back) - Title generator now builds a LanguageModel from the exact model string, via PROVIDER_REGISTRY - Supports anthropic/openai/openrouter/ollama; errors if required API key missing - Removed temporary chat-* fallback path and dead code _Generated with _
- generateWorkspaceName now calls AIService.createModel with the exact model string - Removed provider-specific logic and fallbacks; errors propagate via SendMessageError - Updated ipcMain to pass aiService instead of config _Generated with _
Member
|
I'm a little confused by the purpose of this PR. If we fail to generate the name (IMO) we should generate a placeholder like "-". We should have renaming the workspace automatically after first create and let the user do it as it involves a fallible rename dir operation. |
Contributor
Author
|
@ammario the purpose is to avoid all of that "I'll fix it up later" flow and fail fast before |
- Force NODE_ENV='test' in telemetry client tests so initTelemetry short-circuits - Pin MUX_ROOT to temp .mux in systemMessage tests to avoid host config bleed _Generated with _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the temporary fallback workspace title generation and surfaces provider errors to the user during first-message workspace creation.