This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Add support for specifying GCP instances #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
reviewed
May 1, 2019
Contributor
nhooyr
left a comment
There was a problem hiding this comment.
we can use
$ gcloud compute ssh anmol --dry-run
No zone specified. Using zone [northamerica-northeast1-a] for instance: [anmol].
/usr/bin/ssh -t -i /Users/nhooyr/.ssh/id_ed25519 -o CheckHostIP=no -o HostKeyAlias=compute.627522637120333986 -o IdentitiesOnly=yes -o StrictHostKeyChecking=no -o UserKnownHostsFile=/Users/nhooyr/.ssh/google_compute_known_hosts nhooyr@35.203.36.163
in order to grab the command to be able to ssh into the instance. Might make this code cleaner/more robust.
nhooyr
approved these changes
May 1, 2019
Contributor
nhooyr
left a comment
There was a problem hiding this comment.
otherwise looks reasonable to me
Collaborator
Author
|
Requires some parsing to grab just the flags and ip (have to pass the ssh arguments to rsync), but it'll definitely be a more robust solution. |
44fe18c to
595d918
Compare
- Specifying 'gcp:<instance-name>' for the host argument is now supported for indicating a Google Cloud compute instance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported for indicating a Google Cloud compute instance
resolves #2