Patch for nested shortcode issues #214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
imantsk
approved these changes
Jan 29, 2025
sheabunge
reviewed
Jan 29, 2025
Member
There was a problem hiding this comment.
shortcode_parse_atts should always return an array – if we want to improve resiliency, we should be checking whether $matches[1] exists in the correct form before passing it.
b634094 to
7b4f731
Compare
Member
|
@imantsk what happened here? A force push? Weren't we going to revisit this? |
Member
|
@sheabunge this PR diverged from the core branch creating a merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issues raised on wordpress repo link below, I have amended the shortcode processing code. I did want to retain the functionality added as without it literal shortcodes i.e. [code_snippet id=x] placed in a HTML snippet won't do anything and I think its a valuable enough feature to add.
To summarise. the changes made were to retain the code I added and add the removed code back this way we can do both check for literal shortcodes aswell as handle php code in the HTML snippet where a shortcode may be generated within it
https://wordpress.org/support/topic/3-6-7-broke-shortcode-evaluation/#post-18269725