Skip to content

Merge similar translations strings #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Merge similar translations strings #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee5906
Merge similar translations strings
rami-elementor Apr 26, 2025
844a79a
Merge similar translations strings
rami-elementor Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/components/SnippetForm/page/UpgradeDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,14 @@ const UpgradeInfo: React.FC<UpgradeInfoProps> = ({ nextTab }) =>
className="button button-secondary"
href="https://codesnippets.pro/pricing/"
>
{__('Learn More', 'code-snippets')}
{__('Learn more', 'code-snippets')}
</ExternalLink>

<button
className="button button-primary button-large"
onClick={nextTab}
>
{__('See Plans', 'code-snippets')}
{__('See plans', 'code-snippets')}
<span className="dashicons dashicons-arrow-right"></span>
</button>
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/php/admin-menus/class-manage-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ protected function get_current_type(): string {
*/
public function print_pro_message() {
if ( ! code_snippets()->licensing->is_licensed() ) {
echo '<span class="go-pro-badge">', esc_html_x( 'Pro', 'go pro badge', 'code-snippets' ), '</span>';
Copy link
Member

@sheabunge sheabunge Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to keep this one as-is, as it is not a complete string, and _x provides context indicating that.

echo '<span class="go-pro-badge">', esc_html__( 'Pro', 'code-snippets' ), '</span>';
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/php/admin-menus/class-welcome-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ protected function get_header_links(): array {
$links['pro'] = [
'url' => 'https://codesnippets.pro/pricing/',
'icon' => 'cart',
'label' => __( 'Get Pro', 'code-snippets' ),
'label' => __( 'Upgrade to Pro', 'code-snippets' ),
];
}

Expand Down
2 changes: 1 addition & 1 deletion src/php/class-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public function plugin_action_links( array $actions, string $plugin_file ): arra
'<a href="%1$s" title="%2$s" style="color: #d46f4d; font-weight: bold;" target="_blank">%3$s</a>',
'https://snipco.de/JE2i',
esc_attr__( 'Upgrade to Code Snippets Pro', 'code-snippets' ),
esc_html__( 'Go Pro', 'code-snippets' )
esc_html__( 'Get Pro', 'code-snippets' )
);
}
return $actions;
Expand Down
2 changes: 1 addition & 1 deletion src/php/class-validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public function validate() {
// If we did not make it out of the class, then there's a problem.
if ( $depth > 0 ) {
return array(
'message' => __( 'Parse error: syntax error, unexpected end of snippet', 'code-snippets' ),
'message' => __( 'Parse error: syntax error, unexpected end of snippet.', 'code-snippets' ),
'line' => $token[2],
);
}
Expand Down
5 changes: 2 additions & 3 deletions src/php/cloud/list-table-shared-ops.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,10 @@ function cloud_lts_build_action_links( Cloud_Snippet $cloud_snippet, string $sou
esc_html__( 'Download', 'code-snippets' )
) :
sprintf(
'<a class="cloud-snippet-download %s" href="%s" target="_blank"><span class="go-pro-badge">%s</span>%s</a>',
'<a class="cloud-snippet-download %s" href="%s" target="_blank">%s</a>',
$additional_classes,
'https://codesnippets.pro/pricing/',
esc_html_x( 'Pro', 'pro only', 'code-snippets' ),
esc_html_x( ' Only', 'pro only', 'code-snippets' )
__( '<span class="go-pro-badge">Pro</span> Only', 'code-snippets' ),
);
}

Expand Down
2 changes: 1 addition & 1 deletion src/php/strings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
__( 'Success', 'code-snippets' );
__( 'Notice', 'code-snippets' );
__( 'Thanks', 'code-snippets' );
__( 'Okay', 'code-snippets' );
__( 'Ok', 'code-snippets' );

// settings-fields.php.
__( 'Minify Snippet Output', 'code-snippets' );
Expand Down
4 changes: 2 additions & 2 deletions src/php/views/welcome.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
];

$plugin_types = [
'core' => _x( 'Core', 'badge label', 'code-snippets' ),
'pro' => _x( 'Pro', 'badge label', 'code-snippets' ),
'core' => __( 'Core', 'code-snippets' ),
'pro' => __( 'Pro', 'code-snippets' ),
];

?>
Expand Down