backmerge #238
Merged
backmerge #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core updates
Improve i18n, a11y, and security
Use CSS logical properties to support both LTR & RTL
Minor i18n fix
fix: add missing comma to translation string formatting in safe mode notice
…t and publish artifact link
|
|
||
| if ('markup' === snippetLanguage) { | ||
| snippetCodeModalTag.innerHTML = `<xmp>${snippetCode}</xmp>` | ||
| snippetCodeModalTag.innerHTML = `<xmp>${snippetCodeInput.value}</xmp>` |
Check failure
Code scanning / CodeQL
DOM text reinterpreted as HTML High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the issue, the code should avoid using the xmp tag entirely and instead ensure that the content is safely encoded before adding it to the DOM. Specifically:
- Use
textContentinstead ofinnerHTMLto prevent any interpretation of HTML. - Replace the conditional branch that uses the
xmptag with a safe alternative that ensures the raw code is displayed without escaping it as HTML.
Suggested changeset
1
src/js/services/manage/cloud.ts
| @@ -29,7 +29,7 @@ | ||
| snippetCodeModalTag.textContent = snippetCodeInput.value | ||
|
|
||
| if ('markup' === snippetLanguage) { | ||
| snippetCodeModalTag.innerHTML = `<xmp>${snippetCodeInput.value}</xmp>` | ||
| snippetCodeModalTag.textContent = snippetCodeInput.value | ||
| } | ||
|
|
||
| if ('php' === snippetLanguage) { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.