Skip to content

Conversation

@nepsilon
Copy link
Contributor

@nepsilon nepsilon commented Sep 5, 2013

I saw and fixed 5 typos in the page at chapters/design_patterns/adapter.md.
I also rewrote the problem statement as I found it hard to understand for an English readership.

@sukima
Copy link
Contributor

sukima commented Sep 6, 2013

I have an example for the intro.

I wanted to write a library which would communicate over the network. However the actual implementation of the network code is different between environments (Browser, Node.js, Titanium, etc.)

class NetworkAdapter
  send: (data) ->

class BrowserNetworkAdapter extends NetworkAdapter
  send: (data) ->
    # Do something with XMLHtttpRequest object.

class TitaniumNetworkAdapter extends NetworkAdapter
  send: (data) ->
    # Do something with Ti.Network.HttpClient object.

@peterhellberg
Copy link
Member

@nepsilon Thank you for the changes, I’ll now merge this and add you to the contributors team.

peterhellberg added a commit that referenced this pull request Sep 13, 2013
Anglicize and fix typos for the Adapter design pattern page.
@peterhellberg peterhellberg merged commit 5b2ae1d into coffeescript-cookbook:master Sep 13, 2013
@nepsilon nepsilon deleted the adapter-pattern-typos branch September 14, 2013 06:45
@tashemi
Copy link
Contributor

tashemi commented Sep 25, 2013

@nepsilon thanks for typos correction and anglicizing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants