Bring CoffeeScript idiom to conditional statement.

[nepsilon]

An advantage of CoffeeScript compared to JavaScript is its ability to
check for array membership with the in keyword.
A feature it borrowed from Python.

I thought it could be a good idea to use it whenever possible, as it draws a clear difference between the 2 languages, showcasing a convenient CoffeeScript feature.

[thirdtruck]

Good change. Can you put the array in a semantically-meaningful variable? For example

  successResultCodes = [200, 304]
  if req.status in successResultsCodes

Then it reads even more naturally. :)

[nepsilon]

Good idea.
I just commited this change.

Julien
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, September 5, 2013 at 9:17 PM, James Holder wrote:

In chapters/ajax/ajax_request_without_jquery.md (http://ajax_request_without_jquery.md):

@@ -47,7 +47,7 @@ loadDataFromServer = -> > > req.addEventListener 'readystatechange', -> > if req.readyState is 4 # ReadyState Compelte > - if req.status is 200 or req.status is 304 # Success result codes > + if req.status in [200, 304] # Success result codes
Good change. Can you put the array in a semantically-meaningful variable? For example
successResultCodes = [200, 304] if req.status in successResultsCodes

Then it reads even more naturally. :)

—
Reply to this email directly or view it on GitHub (https://github.com/coffeescript-cookbook/coffeescript-cookbook.github.com/pull/89/files#r6180754).

[thirdtruck]

Glad to help!

On Thu, Sep 5, 2013 at 9:33 AM, nepsilon notifications@github.com wrote:

In chapters/ajax/ajax_request_without_jquery.md:

@@ -47,7 +47,7 @@ loadDataFromServer = ->

req.addEventListener 'readystatechange', ->
if req.readyState is 4 # ReadyState Compelte

•  if req.status is 200 or req.status is 304   # Success result codes
  

•  if req.status in [200, 304]   # Success result codes
  

Good idea. I just commited this change.
… <#140ee54a1c0a3a35_>
-- Julien Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Thursday, September 5, 2013 at 9:17 PM, James Holder wrote: In
chapters/ajax/ajax_request_without_jquery.md (
http://ajax_request_without_jquery.md): > @@ -47,7 +47,7 @@
loadDataFromServer = -> > > req.addEventListener 'readystatechange', -> >
if req.readyState is 4 # ReadyState Compelte > - if req.status is 200 or
req.status is 304 # Success result codes > + if req.status in [200, 304] #
Success result codes Good change. Can you put the array in a
semantically-meaningful variable? For example successResultCodes = [200,
304] if req.status in successResultsCodes Then it reads even more
naturally. :) — Reply to this email directly or view it on GitHub (
https://github.com/coffeescript-cookbook/coffeescript-cookbook.github.com/pull/89/files#r6180754).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/89/files#r6181142
.

[sukima]

I like this. Anyone object to a ?

[peterhellberg]

Looks good to me :)