test: replace try with pytest.raises #1654
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1654 +/- ##
==========================================
Coverage ? 98.64%
==========================================
Files ? 60
Lines ? 2656
Branches ? 0
==========================================
Hits ? 2620
Misses ? 36
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| @pytest.mark.usefixtures("tmp_commitizen_project") | ||
| def test_get_log_as_str_list_empty(): | ||
| """ensure an exception or empty list in an empty project""" |
There was a problem hiding this comment.
Not sure why there are more than one possible behavior in the original test code. That's strange.
There was a problem hiding this comment.
Took a look at the history. Looks like it varies based on the git version.
There was a problem hiding this comment.
We probably need to take a look at which git version changed this
Lee-W
left a comment
There was a problem hiding this comment.
Except for the empty list /exception one, we're good to merge
No description provided.