P3913R1 Optimize for std::optional in range adaptors #8543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
suggested changes
Nov 16, 2025
Member
There was a problem hiding this comment.
Thanks! Just a few details that need adjusting ...
Also, there ought to be a single commit with the message
P3913R1 Optimize for std::optional in range adaptors
Fixes NB PL-011 (C++26 CD).
The 22.5 isn't needed, but the NB is.
The first message on this PR should additionally contain
Also fixes https://github.com/cplusplus/nbballot/issues/783
So that the NB comment issue gets auto-closed.
Fixes cplusplus#8481 Fixes NB PL-011 (C++26 CD) Also fixes cplusplus/nbballot#783
aa0fd28 to
c1f613a
Compare
Add linebreaks around newly added items in the itemize blocks.
eisenwave
approved these changes
Nov 17, 2025
Member
eisenwave
left a comment
There was a problem hiding this comment.
The paper transciption and markup look correct now.
The commit messages aren't exactly in the right format yet (https://github.com/cplusplus/draft/wiki/Applying-papers-to-the-Working-Draft), but Thomas can easily reword those when applying the motions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8481
Fixes NB PL-011 (C++26 CD)
Also fixes https://github.com/cplusplus/nbballot/issues/783