Add Django 2.0 support #67
Conversation
Signed-off-by: Stanislav Filin <stasfilinmusic@gmail.com>
Signed-off-by: Stanislav Filin <stasfilinmusic@gmail.com>
tox.ini
Outdated
| py34-django{18,110,111}, | ||
| py35-django{18,110,111}, | ||
| py36-django{111}, | ||
| py36-django{20}, |
There was a problem hiding this comment.
This could be part of the previous line. ie:
py36-django{111,20},
It's also worth adding ,20 to the py35 line, as Django 2.0 supports that version of python too.
.travis.yml
Outdated
| - PACKAGES="django>=1.8,<1.9" | ||
| - PACKAGES="django>=1.10,<1.11" | ||
| - PACKAGES="django>=1.11,<1.12" | ||
| - PACKAGES="django==2.0" |
There was a problem hiding this comment.
This probably wants to be a little more flexible, to make sure the tests are always run against the latest point release.
To be consistent with the other lines in this file, that would mean changing this to:
PACKAGES="django>=2.0,<2.1"
Although this syntax is more terse:
PACKAGES="django~=2.0.0"
Signed-off-by: Stanislav Filin <stasfilinmusic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 64.98% 64.98%
=======================================
Files 12 12
Lines 794 794
=======================================
Hits 516 516
Misses 278 278
Continue to review full report at Codecov.
|
|
@meshy Hi, I updated .travis.yml and tox.ini how you say |
|
Thanks! |
|
I don't have the power to merge this, but I hope that makes it more acceptable to those that do |
|
@meshy we need to wait for this jazzband/django-polymorphic#318 :) |
|
Thanks a lot! I've merged the fixes, and temporary allow Django 2.0 tests to fail in 7a925a6 (since the polymorphic release is not out yet) |
Hi all, I work on Django 2.0 support.
First we need to wait jazzband/django-polymorphic#318