-
Notifications
You must be signed in to change notification settings - Fork 7.8k
fix(ci): Fix tests and workflows #12024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results152 files 152 suites 1h 0m 52s ⏱️ For more details on these failures and errors, see this check. Results for commit 8669f1c. ♻️ This comment has been updated with latest results. |
79c240c to
4e16236
Compare
Description of Change
This pull request introduces support for passing Wi-Fi credentials dynamically to hardware tests, improving flexibility and enabling tests to run in different Wi-Fi environments. The changes include updates to test scripts, workflow files, and test code to accept and process Wi-Fi SSID and password as arguments, rather than hardcoding them.
Wi-Fi credential handling improvements:
.github/scripts/tests_run.sh: Added support for-wifi-ssidand-wifi-passwordcommand-line arguments, which are passed to pytest and included in test retries. [1] [2] [3]tests/conftest.py: Introduced pytest options and session-scoped fixtures to providewifi_ssidandwifi_passvalues to tests.tests/validation/wifi/test_wifi.py: Updated the test to use the new fixtures, send credentials to the device, and verify they are received correctly. The test now fails if no SSID is provided.tests/validation/wifi/wifi.ino: Modified the firmware to read Wi-Fi credentials from serial input at runtime, instead of using hardcoded values. [1] [2] [3]Workflow and CI integration:
.github/workflows/tests_hw_wokwi.yml,.gitlab/workflows/hw_test_template.yml: Updated workflows to pass Wi-Fi credentials as environment variables and script arguments to the test runner, ensuring tests run with the correct network settings. [1] [2]Other improvements:
tests/pytest.ini: Added configuration to suppress experimental warnings and set the JUnit report family..github/workflows/release.yml: Changed hosted binary copy command to use a more explicit update mode.tests/performance/ramspeed/ramspeed.ino: Improved memory allocation by using specific heap capabilities..github/workflows/tests_hw_wokwi.yml: Reformatted thevariablesblock for readability.Test Scenarios
Tested locally