ext/hash: optional support for the crc-fast library #20513
+1,622
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dramatically increases the performance of all CRC-32 calculations on x86_64 and aarch64 platforms. The latest version of crc-fast (1.6.0 as of this writing) can exceed 110GiB/s on modern hardware. Adds CRC-64 support (both NVME and ECMA-182 variants, the two most popular, used in places like the Linux kernel, AWS S3, etc.), including software fallbacks if the crc-fast library isn’t used. Adds improved industry-standard naming for PHP’s supported CRC-32 variants, since PHP supports both standard (CRC-32/ISCSI and CRC-32/ISO-HDLC) and non-standard calculations but uses confusing, non-standard, and inconsistent naming (`crc32()` and `hash(‘crc32’)` are not the same thing!). The older, non-standard, confusing names can be deprecated at some point in the future, if desired.
Member
|
that is quite a tall change :) that needs to be discussed first however (internal mailing list) at least, that sounds RFC material IMHO too. |
Contributor
Author
|
Looking into the test failure. Looks like unintneional serialization changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dramatically increases the performance of all CRC-32 calculations on x86_64 and aarch64 platforms. The latest version of crc-fast (1.6.0 as of this writing) can exceed 110GiB/s on modern hardware.
Adds CRC-64 support (both NVME and ECMA-182 variants, the two most popular, used in places like the Linux kernel, AWS S3, etc.), including software fallbacks if the crc-fast library isn’t used.
Adds improved industry-standard naming for PHP’s supported CRC-32 variants, since PHP supports both standard (CRC-32/ISCSI and CRC-32/ISO-HDLC) and non-standard calculations but uses confusing, non-standard, and inconsistent naming (
crc32()andhash(‘crc32’)are not the same thing!). The older, non-standard, confusing names can be deprecated at some point in the future, if desired.