Fix GH-20528: Regression breaks mysql connexion using an IPv6 address… #20536
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess enclosed in square brackets
remicollet
referenced
this pull request
Nov 20, 2025
If there are 2 ports, only the first is used. However, then the certificate checking fails. So we drop the second port if there is one. Closes GH-20021.
Member
Author
|
Second commit handles IPv6 address enclosed in square brackets |
| transport.l = mnd_sprintf(&transport.s, 0, "tcp://[%s]:%u", hostname.s, port); | ||
| } else { | ||
| /* Not ipv6, but could already contain a port number, in which case we should not add an extra port. | ||
| char *p; |
There was a problem hiding this comment.
This variable could benefit from having a better name.
"P" is not clear and indicates no purpose.
| char *p; | ||
|
|
||
| /* IPv6 addresses are in the format [address]:port */ | ||
| if (hostname.s[0] == '[') { /* IPv6 */ |
There was a problem hiding this comment.
Add a unit test covering this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… enclosed in square brackets
Notice: this is a minimal fix for the regression GH-20528
So GH-8978 is only partially fixed (missing IPv6 address enclosed in square brackets, ex
[::1]:3306)