one connection type, DataRow now contains payload in ServerMessage #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnikst
approved these changes
Feb 4, 2019
qnikst
left a comment
There was a problem hiding this comment.
Very nice work! Some minor comments though.
tests/Codecs/QuickCheck.hs
Outdated
| decoder = PD.dataRowHeader *> PD.getNonNullable fd | ||
| r <- run $ do | ||
| sendBatchAndSync c [q] | ||
| -- msgs <- collectUntilReadyForQuery c |
| _ <- getByteString len | ||
| pure DataRow | ||
| bs <- getByteString len | ||
| pure $ DataRow bs |
There was a problem hiding this comment.
pure $! DataRow bs
strictness analyzer will likely do this on it's own, but it's safer to be sure.
| countDataRows :: DataRows -> Word | ||
| countDataRows = foldlDataRows (\acc (DataChunk c _) -> acc + c) 0 | ||
| countDataRows :: [B.ByteString] -> Int | ||
| countDataRows = length |
There was a problem hiding this comment.
It seems that the logic changed there, are we guaranteed that there is one row per list element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.