A support of Python v3.8 #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.8 does not support tuple[...], list[...], set[...] and so on. We will use the analogues from typing package: typing.Tuple[...], typing.List[...] and typing.Set[...].
This commit fixes a problem with imports. As I understand 3.8 has a problem with import across root-directory and I do not know/find how to fix it correctly. If someone know how to resolve these problems more easily (through sys.path/__init__.py?) - you are welcome!
We will run all the tests to get a full information about compatibility. Some new tests may fail. --- TODO: may be it is better to compile/install required python version explicitly instead using pyenv.
This reverts commit 96ddf19. It seems to me there was a local gluk. Let's test without these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 does not support list[...], tuple[...], set[...] and so on.
These types were replaced with types from typing. It works in all the versions of python.
Also
This PR is adding into CI a verification for Python 3.8.0, 3.8, 3.9, 3.10 and 3.11.