Skip to content

Conversation

@funbringer
Copy link
Collaborator

Actually, it's a bunch of fixes and improvements.

I decided to move code from _prepare_dirs() into several properties. Note that PostgresNode.base_dir property will not automatically call initdb if there's no such dir.

@funbringer funbringer requested review from gsmolk and ildus March 5, 2018 13:08
@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #38 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   97.17%   97.02%   -0.15%     
==========================================
  Files          16       16              
  Lines        1239     1244       +5     
==========================================
+ Hits         1204     1207       +3     
- Misses         35       37       +2
Impacted Files Coverage Δ
testgres/api.py 100% <100%> (ø) ⬆️
testgres/consts.py 100% <100%> (ø) ⬆️
testgres/node.py 97.26% <100%> (+0.02%) ⬆️
testgres/utils.py 94.89% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4241471...ec94f99. Read the comment docs.

@funbringer funbringer merged commit 70bd512 into postgrespro:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants