-
Notifications
You must be signed in to change notification settings - Fork 148
Implement Sparse Ops in Numba #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
913e012 to
71cc54a
Compare
71cc54a to
1de9697
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (83.20%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
- Coverage 81.70% 81.67% -0.04%
==========================================
Files 246 251 +5
Lines 53632 52549 -1083
Branches 9438 9271 -167
==========================================
- Hits 43822 42919 -903
+ Misses 7329 7258 -71
+ Partials 2481 2372 -109
🚀 New features to boost your workflow:
|
|
Sparse constants don't currently work. Fails during lowering. I am not familiar on how to support this, but it wasn't working before anyway, so this PR is still a strict enhancement |
1de9697 to
14a11e2
Compare
* Handle static shape * Rename to more readable Op classes * Simplify perform
14a11e2 to
285d7ca
Compare
We had support for boxing/unboxing Sparse objects in numba, but we couldn't do anything with them.
This PR implements the basic functionality:
TODO
sparsemodule #1674)📚 Documentation preview 📚: https://pytensor--1676.org.readthedocs.build/en/1676/