Skip to content

Rails 6.1 support and bit type bug fix #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Rails 6.1 support and bit type bug fix #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1fa3747
use ActiveRecord::ConnectionAdapters::SchemaCreation for rails 6.1
lk0001 Jan 19, 2021
77905a4
use just **args instead of options, **args in SQLServerRealTransaction
lk0001 Jan 19, 2021
bc3c149
only use updated initialize arguments in SQLServerRealTransaction for…
lk0001 Jan 19, 2021
3399f41
fix for type_cast_calculated_value has already been applied to rails …
lk0001 Jan 19, 2021
d79cfb1
Remove backward compatible code
wpolicarpo Apr 12, 2021
2b56e52
fixed bug with false default values on bit columns
Circuit8 Feb 17, 2021
80c3b9d
fixed tests
Circuit8 Feb 22, 2021
168ef28
Fixed broken test
Circuit8 Feb 22, 2021
d88d30a
Fixed another broken test
Circuit8 Feb 22, 2021
47f4a5e
Merge branch 'main' into master
Circuit8 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/active_record/connection_adapters/sqlserver/schema_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,12 @@ def column_definitions(table_name)
else
type = case ci[:type]
when /smallint|int|bigint/ then ci[:_type]
when /bit/ then 'smallint'
else ci[:type]
end
value = default.match(/\A\((.*)\)\Z/m)[1]
value = select_value("SELECT CAST(#{value} AS #{type}) AS value", "SCHEMA")

[value, nil]
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/cases/column_test_sqlserver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def assert_obj_set_and_save(attribute, value)
_(col.sql_type).must_equal "bit"
_(col.type).must_equal :boolean
_(col.null).must_equal true
_(col.default).must_equal true
_(col.default).must_equal 1
_(obj.bit).must_equal true
_(col.default_function).must_be_nil
type = connection.lookup_cast_type_from_column(col)
Expand Down