Better conversion from classes to JBBP format #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
did you see new class added no so long time ago in 1.4.0-SNAPSHOT, the class is titled JBBPDslBuilder? it has method to convert annotated classes into JBBP DSL text, take a look at |
Contributor
Author
|
I didn’t see that. I found a snippet somewhere that did the conversion but it broke in a few places so I put this together. If this class you’re working on covers this then maybe this PR should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some trouble a few months back with some code I found to convert from a class to the JBBP representation. I added an interface with default methods called Binary that you can add to a class. When you add it to a class you can then call getFormat() on it to get the JBBP format string for the class.
I used Java 8 for this so I could use default methods and not force every class to extend my base class.
I also updated the gitignore to ignore my Java target directories and fixed a test that wasn't compiling for me. I'm not sure I did the right thing for the test but otherwise I couldn't build it.