Fix GitHub Actions workflow config #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI on this pull request doesn't look right, because it's still using the workflow configuration from main. However, after this PR is merged, other PRs should be processed correctly. |
Member
|
@raxod502 ahh yeah I'm remembering the reason now why I used pull_request_target in the first place: pull_request doesn't have the necessary permissions to merge stuff. See: https://github.com/ruby-syntax-tree/syntax_tree-haml/actions/runs/3223216974/jobs/5273061203. I'll try to find another solution here. |
Contributor
Author
|
Oof, that sucks. I guess you could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
We set CI to run on commits that are merged to main, and also on all commits on open pull requests. There is no need to specifically configure CI to run on merge commits, that is actually the default behavior of actions/checkout@v3 (see docs). And if we specify no trigger types for
pull_request, then it will trigger on every commit to a pull request head branch (but not on commits to non-main branches that have no pull request), see docs.