Skip to content

Conversation

@davidwessman
Copy link

I tried to address #351 since it seemd limited in scope, so hopefully:

I was not sure if the s(:args, children, location) in lib/syntax_tree/translation/parser.rb should be updated as well (tried it but it broke the tests).
And the replacement of parts -> arguments was trial-and-error in a lot of places, since it was hard to know the types of
node.contens.arguments.arguments.arguments or something similar.

Please let me know if I should change anything, or feel free to reject the changes :)

- Fixes #351
- Changed all use of `parts` to `arguments` as well.
@kddnewton
Copy link
Member

Thank you for the contribution! Going to close in favor of the prism branch.

@kddnewton kddnewton closed this Jul 11, 2025
@davidwessman davidwessman deleted the 351-args-to-arguments-node branch July 11, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Args -> ArgumentsNode

2 participants