-
Notifications
You must be signed in to change notification settings - Fork 14k
Update wasm-related dependencies in CI #149037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
r? me @bors r+ |
Update wasm-related dependencies in CI * Update to wasi-sdk-29 released today * Update to Wasmtime 38.0.4 which was released a week or so ago This is the same as #148611, except with wasi-sdk-29 to fixup some issues found in wasi-sdk-28.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
* Update to wasi-sdk-29 released today * Update to Wasmtime 38.0.4 which was released a week or so ago
cafa424 to
4c6e41c
Compare
|
Oh oops no that's a typo on my part, replaced one version but not the other... @bors: r=jieyouxu |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6159a44 (parent) -> a591113 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a591113c0a2b7755514c47bde211fdb92d1d7002 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a591113): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 4.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.7%, secondary 4.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.45s -> 472.582s (-0.18%) |
|
Gotta be noise. A bunch of the changes are benchmarks returning to their previous state, fixing a spurious win. @rustbot label: +perf-regression-triaged |
This is the same as #148611, except with wasi-sdk-29 to fixup some issues found in wasi-sdk-28.