fix: issue 116 - custom_streamable_http_endpoint #117
+219
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @jsudano , thanks for pointing out the issue and suggesting a fix , I really appreciate it! As you mentioned, we don't have unit tests for the HyperServerOptions. It would be great if you could add a test ( a test module at the end of the same file) to cover this fix. |
Author
|
@hashemix thanks for the quick response, and apologies for the delay! I've pushed a couple commits with tests; the first includes a handful of basic tests, and the second adds a dev dependency in order to properly test SSL validation. I broke it into two commits in case you'd prefer not to add any dependencies, in which case I'll remove the second. |
jsudano
commented
Nov 19, 2025
Comment on lines
+607
to
+614
| NamedTempFile::with_suffix(".pem").expect("Expected to create test cert file"); | ||
| let ssl_cert_path = cert_file | ||
| .path() | ||
| .to_str() | ||
| .expect("Expected to get cert path") | ||
| .to_string(); | ||
| let key_file = | ||
| NamedTempFile::with_suffix(".pem").expect("Expected to create test key file"); |
Author
There was a problem hiding this comment.
Just as a note, these files should be dropped when they go out of scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
I noticed while trying to configure a Streamable HTTP MCP server using
HyperServerOptionsthatcustom_streamable_http_endpointdoesn't seem to work. While digging through the code I noticedHyperServerOptions impl'spub fn streamable_http_endpointinstead returns self.custom_messages_endpoint🔍 Related Issues
HyperServerOptions::custom_streamable_http_endpointis not properly used #116✨ Changes Made
HyperServerOptions::streamable_http_endpoint()to consume the propercustom_streamable_http_endpointconfig value.🛠️ Testing Steps
I didn't add unit tests for this because I couldn't find any related tests. Happy to add some unit tests here, not sure if there's a preference on exactly where they should live.