Skip to content

Conversation

@zzgab
Copy link

@zzgab zzgab commented Apr 3, 2014

... Fixes #235 in sebastianbergmann/php-code-coverage

Goes along with commit zzgab/phpunit@232bce6 for sebastianbergmann/phpunit

@zzgab
Copy link
Author

zzgab commented Apr 6, 2014

Can anyone help with this Travis problem: https://travis-ci.org/sebastianbergmann/php-code-coverage/jobs/22277155 ? It does not seem to be related to the commit.

@zzgab zzgab mentioned this pull request Apr 6, 2014
@GrahamCampbell
Copy link
Contributor

Just squash your commits. This will prompt travis to re-run. There should be no composer issue,

…er. Fixes sebastianbergmann#235 in sebastianbergmann/php-code-coverage

Indent with space

phpdoc
@zzgab
Copy link
Author

zzgab commented Apr 6, 2014

Done. Thanks! :)

@zzgab
Copy link
Author

zzgab commented Apr 13, 2014

Any news?

@sebastianbergmann
Copy link
Owner

To be honest, I'd rather remove the prefix than make it configurable.

@zzgab
Copy link
Author

zzgab commented Apr 27, 2014

Fine for me.

@zzgab
Copy link
Author

zzgab commented Apr 27, 2014

Speaking of which, it bothers me that I had to modify the core project phpunit, just so as to grab there the prefix configuration and cascade it onto the coverage report module.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML Breadcrumb shows full local path

3 participants