Little fix for hhvm code coverage #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP_CodeCoverage_Driver is now an abstract class (was an interface before) * Move getAllowedLines and getLinesToBeIgnored() from PHP_CodeCoverage to new PHP_CodeCoverage_Parser class * Move the application of the blacklist/whitelist/"ignored lines" filtering from PHP_CodeCoverage to PHP_CodeCoverage_Driver * Driver-specific data cleanup is now performed after the blacklist/whitelist/"ignored lines" filtering
Allow / as root folder
Contributor
|
Maybe we should change the |
Contributor
|
Any news on this? Also, the indentation is a bit dodgie here. |
Contributor
|
It's a weird situation because Facebook has abandoned their previous code coverage efforts and they are now porting Xdebug. See facebook/hhvm#1589 and facebook/hhvm#2992. |
21b9006 to
dd8c0d3
Compare
Owner
|
I recreated the Please open a new pull request against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hhvm 3.0.1 code coverage actually returns line => invocation count. This patch normalizes to 1.