Skip to content

Conversation

@jg-development
Copy link

No description provided.

sebastianbergmann and others added 30 commits February 24, 2014 13:24
* PHP_CodeCoverage_Driver is now an abstract class (was an interface before)
* Move getAllowedLines and getLinesToBeIgnored() from PHP_CodeCoverage to new PHP_CodeCoverage_Parser class
* Move the application of the blacklist/whitelist/"ignored lines" filtering from PHP_CodeCoverage to PHP_CodeCoverage_Driver
* Driver-specific data cleanup is now performed after the blacklist/whitelist/"ignored lines" filtering
@sun
Copy link

sun commented Aug 19, 2014

s/setter/getter/g in issue title + commit message.

@sun
Copy link

sun commented Aug 19, 2014

Also just noticed that this PR relates to #260 - would be good to include that in the commit message (but don't prefix with "fix", "resolve", or "close", as that would preemptively close #260).

@sebastianbergmann
Copy link
Owner

I recreated the master branch based on the 2.0 branch thus reverting all the changes I made in master since 2.0 was originally branched off. This makes this pull request unusable. I apologize for any inconvenience this may cause.

Please open a new pull request against the 2.0 branch if this is a backwards compatible bugfix or against master if it is not. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants