Add freeze prop to stop dragging events #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanesarango
approved these changes
Sep 14, 2017
|
Could you try to solve the conflicts? |
Author
|
If someone is planning to actually merge this PR, yes ;) |
|
@wangzuo Any plans on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't prevent the tree from being modified in the
onChangeevent so this PR just adds a new prop to make it easy to stop dragging events. I didn't name the propeditablein order not to break compatibility with current code.If you think this is a good idea, please feel free to change the prop name or modify the code in any other way.
Thanks a lot for this useful React component!