Bundle manifest #3997
Open
Bundle manifest #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c892337 to
f56f0cb
Compare
Contributor
Author
|
It's probably better to name this file something like |
f56f0cb to
280b7e5
Compare
Contributor
I'd prefer this to be mkosi-named, otherwise the name is too generic and similar to |
280b7e5 to
07aa7c2
Compare
If json manifest is requested and metadata would not be cleaned due to CleanPackageMetadata=, write the manifest to the OS image under the same condition as when os-release would be written (i.e. not sysext, confext, addon, or overlay).
07aa7c2 to
8ab8d95
Compare
Contributor
Author
|
Sounds right to me. Just pushed a change to change from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to close #3995. Writes the json manifest to /usr/lib/os-manifest. Maybe it's too presumptuous to claim that path, but naming is hard and I had to pick something.
Since the manifest takes up only ~300k with >2000 packages, compressing the manifest didn't seem to make sense.