Using of HandleErrorAttribute in ASP.NET MVC application

Question

I have a question about the best way of using HandleErrorAttribute in my MVC 5 application. As we know, we can add this attribute to global filters like that:

 filters.Add(new HandleErrorAttribute{View = "Error"});

This involves the app to show the 'Error' view every time when an unhandled exception is thrown in any level of app. But, if I have some logic in another global authorize or action filter, that produces some exception, then when the exception is thrown for first time, the app tries to redirect to the Error View, again other filters begin executing and produce the same exception again, so asp.net to avoid looping terminates the app. So what is the best way to use this HandleErrorAttribute to avoid such behavior? Thanks!

Edit: After some debugging I found that this is not the usual behavior of HandleErrorAttribute, so looping happens for me only when I use custom Routes f.e.

{key}/{controller}/{action}

and when some error occurs in the filter logic, then the app tries to redirect to the Error View, but again another filter logic begins to exectue and I even see an "Error" value in the {key} route parameter, so it is unwanted behavior. When I use the default route {controller}/{action} this doesn't happen and I get exactly to the Error View without executing any global filter logic a second time.

Mathew Thompson · Accepted Answer · 2013-09-26 10:59:24Z

11

You should wrap your action filter logic inside a try catch, then inside the catch block, redirect to the Error view and pass the Exception.

Your only other alternative is to ditch HandleError completely and use the Application_Error event inside Global.asax to manage your error handling. That way you can redirect to your Error action inside there regardless of where the error occured.

answered Sep 26, 2013 at 10:59

Mathew Thompson

56.5k15 gold badges131 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

igorGIS Over a year ago

Thanks! This is a nice approach.

Murali Murugesan Over a year ago

what about using ELMAH?

Mathew Thompson Over a year ago

@Murali I'm not a fan of ELMAH to be honest

igorGIS Over a year ago

Guys, what you think about what i added in Edit? Can custom route fetch to such incorrect behavior of HandleErrorAttriubute? Because i re-check it twice, and when route it default it works just fine as expected, no any other filters logic fires twice

Mike Cole Over a year ago

@mattytommo what's your beef with elmah, out of curiosity?

|

KevinB · Accepted Answer · 2014-02-06 21:33:51Z

3

Matt is right about global.asax... this is the example I followed http://www.digitallycreated.net/Blog/57/getting-the-correct-http-status-codes-out-of-asp.net-custom-error-pages

Then in each view I added: Response.StatusCode = 500; or which ever other code I wanted to show back to the client.

answered Feb 6, 2014 at 21:33

KevinB

1,4071 gold badge9 silver badges10 bronze badges

Collectives™ on Stack Overflow

Using of HandleErrorAttribute in ASP.NET MVC application

2 Answers 2

6 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related