How to generate multiple response.write:s with json in node.js/express?

Question

Having some trouble with generating multiple response.write:s from an api call in node.js. Here is the code.

 // get the articles
app.get('/api/articles', function(req, res) {


res.writeHead(200, {
    "Content-Type": "application/json"
});
// use mongoose to get all feeds in the database
Feed.find(function(err, feeds) {
    // if there is an error retrieving, send the error. nothing after     res.send(err) will execute
    if (err)
        res.send(err);

    feeds.forEach(function(feedModel) {
        //for each feed in db get articles via feed-read module
        feed(feedModel.url, function(err, articles) {
            articles.forEach(function(articleModel) {
                console.log(JSON.stringify(articleModel));//works!!
                res.write(JSON.stringify(articleModel));//doesnt produce output.
            });
        });
    });
}); //end find function
res.end();
}); //end api call

Hi! After some tinkering I got it to work by removing the res.writeHead and res.end lines. Apparently I will trigger two writeHead with the previous code and by removing the lines node or express will "automagically" fix the headers. — user3422843
– user3422843, Commented Jul 5, 2015 at 20:10
I got the idea from to post: stackoverflow.com/questions/17628052/… — user3422843
– user3422843, Commented Jul 5, 2015 at 20:10

beautifulcoder · Accepted Answer · 2015-07-05 13:39:54Z

1

You need to end() inside the callback no at the end.

res.end(JSON.stringify(articleModel));

answered Jul 5, 2015 at 13:39

beautifulcoder

11.4k3 gold badges21 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3422843 Over a year ago

Ok. tried that. Now the first feed actually shows up but not the rest. I am thinking thats because we actually end prematurely before we are done processing the rest of the feeds? how would I merge all the articleModels in a list then just using the one res.end statement to send the respond back?

beautifulcoder Over a year ago

Then you'll need promises, or a mechanism to manage callbacks. But that is a separate question.

user3422843 · Accepted Answer · 2015-07-05 20:11:06Z

0

After some tinkering I got it to work by removing the res.writeHead and res.end lines. Apparently I will trigger two writeHead with the previous code and by removing the lines node or express will "automagically" fix the headers. /Stefan

answered Jul 5, 2015 at 20:11

user3422843

236 bronze badges

1 Comment

user3422843 Over a year ago

I got the idea from to post: stackoverflow.com/questions/17628052/…

Collectives™ on Stack Overflow

How to generate multiple response.write:s with json in node.js/express?

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related