Comparing string array to variable Java [duplicate]

Question

I have a dilemma I am trying to find out the best way to compare a string variable called (code) to an array of strings. if it equal it i want it to break the for loop. Which would should I select. I think the 2nd one will work but the 1st one seems like it would and its simpler. Any advice would be appreciated.

String[] badcodes = {"8QQ", "8BQ", "8JQ"};
if (code.equals(badcodes)) {
    break;
}

String[] badcodess = {"8QQ", "8BQ", "8JQ"};
for (String s : badcodess) {
    if (s.equals(code)) {
        break; // break out of for loop
    }
}

--------------based on answer ----------------------

String[] badcodes = {"8QQ", "8BQ", "8JQ"};
boolean check = Arrays.asList(badcodess).contains(code);
if (check = true) {
    // do something
} else {
    // do something
}

You mean, if any of the strings in the array equals the value of code? — Federico klez Culloca
– Federico klez Culloca, Commented Mar 14, 2018 at 16:35
"compare a string variable called (code) to an array of strings" A String will never be equal to a String[] — takendarkk
– takendarkk, Commented Mar 14, 2018 at 16:35

Youcef LAIDANI · Accepted Answer · 2018-03-14 16:35:24Z

2

You can convert your array to a List then use List::contains to check if the list contain the code or not :

boolean check = Arrays.asList(badcodess).contains(code);

answered Mar 14, 2018 at 16:35

Youcef LAIDANI

60.2k21 gold badges111 silver badges178 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Jonathan Over a year ago

I wrote some code above I want to use an if statement, would that work ? since check in boolean i am checking if it is true or not correct?

Youcef LAIDANI Over a year ago

@Jonathan you can just use if (check){//do something}else{//do something else} no need to use check = true this is an assignment and not comparing, to check if a check equals to true or not you need to use double equal

Jonathan Over a year ago

so your saying I dont have to write check = true ?

Youcef LAIDANI Over a year ago

exactly just use if(check) it equivalent to if(check == true)

Jonathan Over a year ago

OKAY I see if it contain the code do this if not do this check = true is not needed because if it equals true your going to do something anyway... I see i got it

GhostCat · Accepted Answer · 2018-03-14 16:35:12Z

2

Your first option would not do what you expect to do. And even if someArray.equals(anotherArray) would do an element-wise comparison (which it doesn't) - you would need to have the special array contain all objects of the existing array, in the exact same order. In that sense: first understand why this approach is flawed in many ways, to then drop it.

The second option is fine, but if you really want to "improve" the whole thing - use ArrayList instead - which has a contains() method.

answered Mar 14, 2018 at 16:35

GhostCat

141k28 gold badges190 silver badges262 bronze badges

Collectives™ on Stack Overflow

Comparing string array to variable Java [duplicate]

2 Answers 2

5 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Linked

Related