Undefined index with Laravel

Question

Getting "undefined index wars" on command and it was working before. But now when I run the command on a moved server it just errors out. I don't know if I'm missing an obvious answer or what.

    public function __construct(int $numWars = 500)
    {
        $client = new PWClient();
        $json = $client->getPage("http://game.com/api/wars/{$numWars}/?key=".env("API_KEY"));
        $decoded = \json_decode($json, true);
        $this->result = Collection::make($decoded["wars"]);
    }

Possible duplicate of "Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset" using PHP — atymic
– atymic, Commented Jul 23, 2019 at 4:31

atymic · Accepted Answer · 2019-07-23 04:32:41Z

1

You are getting that error because the key wars doesn't exist on the response.

Most likely, the API you are querying has changed it's response format. You should check the documentation for it, and update your code.

answered Jul 23, 2019 at 4:32

atymic

3,1481 gold badge15 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

HeyItsAlex Over a year ago

Actually looking deeper, this was the issue.

Ezequiel Fernandez · Accepted Answer · 2019-07-23 04:45:27Z

0

Your $json is missing something:

Try this:

public function __construct(int $numWars = 500)
{
   $client = new PWClient();

   $key = env("API_KEY");
   $json = $client->getPage("http://game.com/api/wars/{$numWars}/?key={$key}");

   $decoded = json_decode($json, true);

   if(!empty($decoded['wars'])){
       $this->result = Collection::make($decoded["wars"]);
   }else{
       dump('decode variable does not have wars key or is empty:');
       dd($decoded);
   }

}

answered Jul 23, 2019 at 4:45

Ezequiel Fernandez

1,08413 silver badges20 bronze badges

Collectives™ on Stack Overflow

Undefined index with Laravel

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related