PHP Undefined variable: array [duplicate]

Question

I need to check whether selected city ( $_GET['city'] ) behaves in $cities array or not. Right now i'm getting errors "Undefined variable: cities" and "Invalid argument supplied for foreach()". If i check $cities with is_array it returns true. How can i fix my code?

$cities = array ("London" => "name/name2/name3", 
"Paris" => "name/name3/name4", 
"Moscow" => "name/name5/name6", 
"Paraguay" => "name/name4/name5");



function CityIsCorrect() {                                                                  //IN WORK
        if (empty($_GET['city'])) {return false;}
        foreach ($cities as $citycheck){
            if(($_GET['city'])==$citycheck) {return true;}
            else {return false;}
        }
}

Hi, it is related to scope, in PHP a function block code doesn't know/have access to the variables outside its block, so $cities is undefined inside CityIsCorrect() function. You would need to add a parameter $cities to the function and pass the variable $cities when calling the function. — Jubei
– Jubei, Commented Mar 23, 2020 at 19:40

Mike Robinson · Accepted Answer · 2020-03-23 19:43:51Z

0

To directly answer your question – add this line to your function:

global $cities

By default, all variables within a function are "local." If you want to refer to a global function (a variable declared outside of any function-block), you must use global.

answered Mar 23, 2020 at 19:43

Mike Robinson

9,0516 gold badges33 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nigel Ren Over a year ago

stackoverflow.com/questions/12445972/stop-using-global-in-php

Collectives™ on Stack Overflow

PHP Undefined variable: array [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related