Optimization on List key comparisons and return value with HashMap

Question

Consider this code:

           public class DataSt {

            DataType time;
            DataType memory;


            public DataSt(DataType time, DataType memory)
            {
                this.time=time;
                this.memory=memory;
            }

            private static void saveIt(DataSt p, DataSt p2, String keyval, List<DataSt> comp) {      
                  ...
                }


            private static void saveIt( String keyval, List<DataSt> comp) {
                     ...
         }

            public static List<DataSt> compO(List<DataSt> curR, List<DataSt> prevR) {            
                Map<String,DataSt> cur = new HashMap<>();Map<String,DataSt> prev= new HashMap<>();      
                for(DataSt abc:curR)
                {
                    DataSt v = new DataSt (abc.time,abc.memory);
                    cur.put(abc.key,v);
                }

                for(DataSt abc:prevR)
                {
                    DataSt values = new DataSt (abc.time,abc.memory);
                    prev.put(abc.key,v);
                }

                List<DataSt> comp = new ArrayList<DataSt>();

                for (Entry < String, DataSt > abc: cur.entrySet()) {
                    if (prev.containsKey(abc.getKey())) {
                        saveIt(abc.getValue(), prev.get(abc.getKey()), abc.getKey(), comp);
                    } else {
                        saveIt(abc.getKey(), comp);
                    }
                }

                for (Entry<String, DataSt> abc: prev.entrySet()) {
                    if (!(cur.containsKey(abc.getKey()))) {
                        saveIt(abc.getKey(), comp);
                    }
                }   
                return comp;
            }
        }

With reference to the link "https://stackoverflow.com/questions/45230104/list-key-comparisons-and-return-value". It would be great if someone could review the code and suggest optimizations.

You've added the performance tag. Do you experience any performance issues? — t3chb0t
– t3chb0t, Commented Jul 26, 2017 at 10:58
@t3chb0t no I don't....... just wanted to make sure I have a well optimized code w.ref. to the link "stackoverflow.com/questions/45230104/…" as I need to store the final comparison result into a List where the comparison turns little hard w.r.t ArrayList as suggested in the above link... — nt fury
– nt fury, Commented Jul 27, 2017 at 9:44

nt fury · Accepted Answer · 2017-07-27 10:53:48Z

public static List<DataSt> compO(List<DataSt> curR, List<DataSt> prevR) {

    Map<String,DataSt> cur = new HashMap<>();Map<String,DataSt> prev= new HashMap<>();
   curR.parallelStream().forEach(entry -> cur.put(entry.key,new DataSt (entry.time,entry.memory)));
   prevR.parallelStream().forEach(entry -> prev.put(entry.key,new DataSt (entry.time,entry.memory)));

    List<DataSt> comp = new ArrayList<DataSt>();
    for (Entry < String, DataSt > abc: cur.entrySet()) {
        final String key = abc.getKey();
        if (prev.containsKey(key)) {
            saveIt(abc.getValue(), prev.get(key), key, comp);
        } else {
            saveIt(key, comp);
        }
    }

    for (Entry<String, DataSt> abc: prev.entrySet()) {
        final String key = abc.getKey();
        if (!(cur.containsKey(key))) {
            saveIt(key, comp);
        }
    }
    return comp;
}

Also you can try to use parallel stream on map, but it should not be HashMap, and I'm not sure that it will be faster.

\$\begingroup\$ Please, mark this answer as right if it is true. \$\endgroup\$

Eugene Ustimenko
– Eugene Ustimenko

2017-07-27 09:59:13 +00:00
Commented Jul 27, 2017 at 9:59 — Eugene Ustimenko
– Eugene Ustimenko, Commented Jul 27, 2017 at 9:59

Stack Exchange Network

Optimization on List key comparisons and return value with HashMap

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Optimization on List key comparisons and return value with HashMap

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions