Open database and hande errors

Question

How to make this code better?

if (Program.Data.DataBase.TryOpenDataBase())
{
 bool result; 
 DataBase= new Program.Data.DataBase(out result);
 if (!result)
 {
    if (Program.DataBase!= null) 
       Program.DataBase.Dispose();
     Program.DataBase= null;
     Log.WriteERROR("Can not open database");
     Application.Exit();
     return;
 }
 else
 {
    Log.WriteERROR("Can not open database");
    Application.Exit();
    return;
 }

There's a lot of stuff here that appears to be proprietary and has no real meaning in a usable context. Are you using MSSQL, MySQL, Oracle? What does TryOpenDataBase() look like? What is DataBase? — Joel Etherton
– Joel Etherton, Commented May 5, 2011 at 14:22

Skeeterbug · Accepted Answer · 2011-05-05 22:23:32Z

4

I would remove the out parameter from the constructor. It is really confusing to read. Maybe create a function that throws an exception instead. If the database implements IDisposable you can use a using block instead.

Edit - You have some duplicate code as well:

Log.WriteERROR("Can not open database");
Application.Exit();
return;

answered May 5, 2011 at 22:23

Skeeterbug

3111 silver badge2 bronze badges

Add a comment |

pabdulin · Accepted Answer · 2011-05-08 17:55:30Z

1

Generally you shouldn't return any error codes, use exceptions and try/catch blocks.

answered May 8, 2011 at 17:55

pabdulin

1112 bronze badges

\$\begingroup\$ To be clear, returning the error code doesn't just have be the return value of the method, it could be an out parameter. This is still usually a bad thing. \$\endgroup\$

mjcopple
– mjcopple

2011-05-26 20:55:06 +00:00
Commented May 26, 2011 at 20:55

Add a comment |

Stack Exchange Network

Open database and hande errors

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Open database and hande errors

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions