Basic form validation script

Question

Is this a good form validation script?

$(document).ready(function() {

    $("form").submit(function() {

        var shouldSubmit = true;

        $(this).children(":input:not(:button, [type=\"submit\"], [type=\"reset\"])").each(function() {

            if ($(this).val() == "")
            {
                shouldSubmit = false;
                return shouldSubmit;
            }

        });

        if ($("input:checkbox").length > 0)
        {
            if ($("input:checkbox:checked").length == 0)
                shouldSubmit = false;
        }

        if ($("input:radio").length > 0)
        {
            if ($("input:radio:checked").length == 0)
                shouldSubmit = false;
        }

        if (shouldSubmit == false)
            alert("All form fields must be filled out.");

        return shouldSubmit;

    });

});

Have a look at this method: api.jquery.com/is You can save some work by doing something like if($("input:radio").is("checked)). Also you can just return false right away instead of setting a boolean then returning false. — Jonny Sooter
– Jonny Sooter, Commented Jul 16, 2013 at 16:39

user26977 · Accepted Answer · 2013-07-16 18:56:49Z

1

The if statements could be cleaner:

    if ($("input:checkbox").length > 0 && $("input:checkbox:checked").length == 0)
    {
        shouldSubmit = false;
    }

    if ($("input:radio").length > 0 && $("input:radio:checked").length == 0)
    {
        shouldSubmit = false;
    }

    if (!shouldSubmit)
    {
        alert("All form fields must be filled out.");
    }

answered Jul 16, 2013 at 18:56

user26977

Add a comment |

Stack Exchange Network

Basic form validation script

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Basic form validation script

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions