SPFile.OpenBinary throwing error "Cannot open file"

Question

I have the chunk of code below:

SPListItem source = //some list item;
foreach (string file in source.Attachments)
{
    SPFile oFile = source.Web.GetFile(file);
    string strFilename = oFile.Name;
    byte[] binFile = oFile.OpenBinary();  //Errors out here!
    destination.Attachments.Add(oFile.Name, binFile);
    destination.SystemUpdate();
}

Which throws this error:

EXCEPTION in CrossSiteCopy! Cannot open file "2012-05-21_104000.png". at Microsoft.SharePoint.SPGlobal.HandleComException(COMException comEx) at Microsoft.SharePoint.Library.SPRequest.GetFileAsStream(String bstrUrl, String bstrWebRelativeUrl, Boolean bHonorLevel, Byte iLevel, OpenBinaryFlags grfob, String bstrEtagNotMatch, String& pEtagNew, String& pContentTagNew) at Microsoft.SharePoint.SPFile.GetFileStreamCore(OpenBinaryFlags openOptions, String etagNotMatch, String& etagNew, String& contentTagNew) at Microsoft.SharePoint.SPFile.GetFileStream(OpenBinaryFlags openOptions, String etagNotMatch, String& etagNew, String& contentTagNew) at Microsoft.SharePoint.SPFile.OpenBinary(SPOpenBinaryOptions openOptions) at Copy_Special.CrossSiteCopy.CopyFieldValues(SPListItem source, SPListItem destination) at Copy_Special.CrossSiteCopy.<>c_DisplayClass1.b_0() at Microsoft.SharePoint.SPSecurity.<>c_DisplayClass4.b_2() at Microsoft.SharePoint.Utilities.SecurityContext.RunAsProcess(CodeToRunElevated secureCode) at Microsoft.SharePoint.SPSecurity.RunWithElevatedPrivileges(WaitCallback secureCode, Object param) at Microsoft.SharePoint.SPSecurity.RunWithElevatedPrivileges(CodeToRunElevated secureCode) at Copy_Special.CrossSiteCopy.Execute(ActivityExecutionContext executionContext)

It's not giving me much information about WHY it cannot open the file. Can any one point me to what the problem might be?

Can you check the SP log? Also, Can you make sure the source exists (wherever the file is)? — Maria Burton
– Maria Burton, Commented Jun 13, 2012 at 16:03

Lars Fastrup · Accepted Answer · 2012-06-13 16:10:42Z

2

You need to specify more than just the attachment file name in the SPWeb.GetFile method! Specify the Web relative file URL or the server relative file URL here. You can construct the Web relative file URL from source.Attachments.UrlPrefix + file

answered Jun 13, 2012 at 16:10

Lars Fastrup

3,1402 gold badges23 silver badges29 bronze badges

1

Instead of just using + to combine URLs you should use SPUrlUtility.CombineUrls

Per Jakobsen
– Per Jakobsen

2012-06-13 17:56:25 +00:00
Commented Jun 13, 2012 at 17:56
Thx was not aware of this util method! Anyway, I agree and am also using my own util Url.Combine that is not so SharePoint specific. It also takes any number of string inputs for combination.

Lars Fastrup
– Lars Fastrup

2012-06-14 07:34:25 +00:00
Commented Jun 14, 2012 at 7:34

Add a comment |

Stack Exchange Network

SPFile.OpenBinary throwing error "Cannot open file"

1 Answer 1

Your Answer

Hot Network Questions

SPFile.OpenBinary throwing error "Cannot open file"

1 Answer 1

Your Answer

Sign up or log in

Post as a guest

Related

Hot Network Questions