PHP SQL Function

Question

Can someone please tell me why my function is not working?

function myappsbdo($sqlquery, $tabname)
{
try
    {
        $pdo = new       PDO("mysql:host=127.0.0.1;port=3306;dbname=myapps","root","");
    }
catch (PDOException $e)
    {
        echo "Problème de connexion";
        exit();
    }
$sql = $sqlquery;
        $result = $pdo->query($sql);
        $tabname  = $result->fetchALL(PDO::FETCH_NUM);
}

I do a var_dump of the variable I chose for my $tabname and it's an empty array. There is suppose to have my db data in it... Thanks!

EDIT: this is how I call it. myappsbdo("SELECT * FROM categorie", $tab1);

What is the value of $tab1 when you call it? Seems like it is not initialized yet. — Chris Trahey
– Chris Trahey, Commented Dec 14, 2012 at 1:57

eggyal · Accepted Answer · 2012-12-14 02:12:34Z

1

The function argument $tabname was passed by value, therefore your subsequent assignment to that variable changes only the value of the function-scoped variable $tabname and not of the calling-scoped variable $tab1.

You want to pass by reference instead:

function myappsbdo($sqlquery, &$tabname) {
  //                          ^---- notice the ampersand character
  // etc.
  $tabname = $result->fetchALL(PDO::FETCH_NUM);
}

Or, alternatively, return the resultset:

function myappsbdo($sqlquery) {
  // etc.
  return $result->fetchALL(PDO::FETCH_NUM);
}

$tab1 = myappsbdp('SELECT * FROM categorie');

Note that you probably ought to make your PDO object static, so that the database connection can be reused in successive function calls.

answered Dec 14, 2012 at 2:12

eggyal

127k18 gold badges220 silver badges244 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1834464 Over a year ago

Thanks, I forgot to return the value haha.

Collectives™ on Stack Overflow

PHP SQL Function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related