mysql query and result statement in a function

Question

I am wondering I have been trying to place me MySQL query and MySQL result code into a PHP function like this

 function setting($claim){
    $query = "SELECT `cases`, `hg`, `surname`, `firstname`, `type`, `claim`, `charge`, `damage`, `payment`, `repair`, `returned`, `comments`, `cost` FROM `rep_log` WHERE claim='$claim'";
    $result = mysql_query($query) or die(mysql_error());
}

I'm trying to use this so that I can make it easier to change what is being selected without having to have heaps of different variables and stuff just to change the query... so basically what I do is

echo setting("warrenty");

But I'm getting an error:

Warning: mysql_fetch_row() expects parameter 1 to be resource, string given in ...

So I am wondering is it even possible to put a MySQL query and result into a function or is it just something which cannot happen...

If it is possible any help would be great.

COMPLETE CODE

<?
// connection with the database
$dbhost = "localhost";
$dbuser = "root";
$dbpass = "";
$dbname = "netbookdb";
$result="";
mysql_connect($dbhost,$dbuser,$dbpass);
mysql_select_db($dbname);

// require the PHPExcel file
require 'Classes/PHPExcel.php';

// simple query
 function setting($claim){
    $query = "SELECT `cases`, `hg`, `surname`, `firstname`, `type`, `claim`, `charge`, `damage`, `payment`, `repair`, `returned`, `comments`, `cost` FROM `rep_log` WHERE claim='$claim'";
    $result = mysql_query($query) or die(mysql_error());
}



    // Create a new PHPExcel object
   $objPHPExcel = new PHPExcel();
   $objPHPExcel->getActiveSheet()->setTitle('Insurance');

echo setting('Warrenty');


$rowNumber = 1;
    while ($row = mysql_fetch_row($result)) {
       $col = 'A';
       foreach($row as $cell) {
          $objPHPExcel->getActiveSheet()->setCellValue($col.$rowNumber,$cell);
          $col++;
       }
       $rowNumber++;
    }


   // Save as an Excel BIFF (xls) file
   $objWriter = PHPExcel_IOFactory::createWriter($objPHPExcel, 'Excel5');

   header('Content-Type: application/vnd.ms-excel');
   header('Content-Disposition: attachment;filename="myFile.xls"');
   header('Cache-Control: max-age=0');

   $objWriter->save('php://output');
   exit();

echo 'a problem has occurred... no data retrieved from the database';
?>

im getting an error that basicly says that no query has been ran and no result has been returned... Can you please post the exact error message you get instead of writing it in your own words? — Mark Byers
– Mark Byers, Commented May 25, 2012 at 5:37
this error <b>Warning</b>: mysql_fetch_row() expects parameter 1 to be resource, string given in — Matthew
– Matthew, Commented May 25, 2012 at 5:39
Where do you call mysql_fetch_row()? Can you post the code for that? — Mark Byers
– Mark Byers, Commented May 25, 2012 at 5:40

talha2k · Accepted Answer · 2012-05-25 06:06:21Z

4

You are not returning any result out of a function.

Use return $result;

UPDATE 1:

You have not decalred the $result variable which you are trying to use in mysql_fetch_row so first return the value from the function assign it and then use it.

UPDATE 2:

function setting($claim){
    $query = "SELECT `cases`, `hg`, `surname`, `firstname`, `type`, `claim`, `charge`, `damage`, `payment`, `repair`, `returned`, `comments`, `cost` FROM `rep_log` WHERE claim='$claim'";
    $result = mysql_query($query) or die(mysql_error());
    return $result;
}

and then get the output of function in a variable which you are using in mysql_fetch_row method. i.e.

$result = setting('Warrenty');

Hope this helps.

edited May 25, 2012 at 6:06

answered May 25, 2012 at 5:36

talha2k

25.5k4 gold badges67 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Matthew Over a year ago

i am trying to use the result later on in the script but that all works fine its only when its in the fucntion does it not work

Mark Byers Over a year ago

@Matthew: Have you tried doing what AlphaMale has suggested? If not, please try it first before commenting on why you think it might not work. If you have tried it then be more specific about what new problem you have. Post the new error message.

talha2k Over a year ago

@MarkByers you are right he is not using the result variable correctly.

Matthew Over a year ago

i have read the update but i dont understand what u mean one i echo the function shouldn't MySQL_fetch_row see the result and continue to run

talha2k Over a year ago

Nope. unless and untill you return the result.

|

jfoliveira · Accepted Answer · 2012-05-25 05:47:50Z

0

You are assigning a local "$result" variable, so "mysql_fetch_row($result)" is using the string variable "$result", initialized as "$result = ''", that is not a resource and therefore will raise the exception.

In the "setting" function, put add "global $result;" line:

function setting($claim){
global $result;
    $query = "...;
    ...
}

answered May 25, 2012 at 5:47

jfoliveira

2,17014 silver badges27 bronze badges

Collectives™ on Stack Overflow

mysql query and result statement in a function

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related