Powershell variable not passed into filter

Question

I need to create scirpt which add users from list (containing user Display name) to group Problem I encountered is : when I issue command :

PS C:\Users\pskwarek> foreach ($a in $csv) {(get-aduser -f "DisplayName -like 'Piotr Skwarek'").samaccountname}
pskwarek
pskwarek

but if I use $a variable it doesnt work :

PS C:\Users\pskwarek> foreach ($a in $csv) {(get-aduser -f "DisplayName -like '$a.name'").samaccountname}

next step I would like to pass it to :

Add-adgroupMember -identity "groupname" -member samaccountname

but I can't make that single step

edit

PS C:\Users\pskwarek> $csv
Name
----
Piotr Skwarek
Renata Skwarek

PS C:\Users\pskwarek> $csv Name ---- Piotr Skwarek Renata Skwarek — piosk
– piosk, Commented Mar 4, 2013 at 13:37

Shay Levy · Accepted Answer · 2013-03-04 13:51:50Z

2

You need to put $a.name in a subexpression:

foreach ($a in $csv) 
{
    $user = Get-ADUser -Filter "DisplayName -like '$($a.name)'" 
    Add-ADGroupMember groupname -Members $user
}

edited Mar 4, 2013 at 13:51

answered Mar 4, 2013 at 13:45

Shay Levy

128k34 gold badges193 silver badges210 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Poorkenny Over a year ago

The syntax of that solution is actually clearer than mine, I always forget about this :p

mjolinor · Accepted Answer · 2013-03-04 13:47:35Z

0

foreach ($a in $csv) 
{
 $sb = [scriptblock]::create("DisplayName -like '*$a*'")
 (get-aduser -f $sb).SamAccountName
}

answered Mar 4, 2013 at 13:47

mjolinor

68.7k7 gold badges118 silver badges141 bronze badges

Comments

Poorkenny · Accepted Answer · 2013-03-04 13:47:50Z

0

Try this:

foreach ($a in $csv) {(get-aduser -f ("DisplayName -like '{0}'" -f $a.name)).samaccountname}

You cannot use members of a variable directly in a string as you did. Using string formatting (the '-f' syntax I proposed) always works. Another solution would be to use a temporary variable to store $a.name

answered Mar 4, 2013 at 13:47

Poorkenny

1,25611 silver badges16 bronze badges

2 Comments

piosk Over a year ago

I am new to scripting and have to admit I don't get it altough it worked fine thx

Poorkenny Over a year ago

Basically, in PS, you can construct strings and put "placeholders" for variables in them: $string = ("This is {0} {1}" -f "my","script") This just tells PowerShell to replace {0} by the first element of the list that's placed after '-s', and {1} by the second, and so on.

CB. · Accepted Answer · 2013-03-04 14:03:07Z

0

Try this:

$csv | % { Add-ADGroupMember -Identity "Groupname" -Member $_.Name  }

edited Mar 4, 2013 at 14:03

answered Mar 4, 2013 at 13:43

CB.

61.3k9 gold badges171 silver badges165 bronze badges

Collectives™ on Stack Overflow

Powershell variable not passed into filter

4 Answers 4

1 Comment

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related