Checking string, regex issue?

Question

Currently I am checking a string for the following:

if(parseCommand.contains("vlan1") || parseCommand.contains("Fa0/1i")
  || parseCommand.contains("Fa0/1o") || parseCommand.contains("Fa1/0")                              
  || parseCommand.contains("Fa1/1") || parseCommand.contains("Fa1/2")
  || parseCommand.contains("Fa1/3") || parseCommand.contains("Fa1/4")
  || parseCommand.contains("Fa1/5") || parseCommand.contains("Fa1/6")                                    
  || parseCommand.contains("Fa1/7") || parseCommand.contains("Fa1/8") 
  || parseCommand.contains("Fa1/9") || parseCommand.contains("Fa1/11") 
  || parseCommand.contains("Gi0")) {
//do things here                              
}

However it may contain vlan1 up to vlan4094 and i have to check for these. What is the simplest way to do this?

I have tried this just to match a vlan 1-9 folowed by 0-3 digits but it doesn't find anything:

if(parseCommand.matches(".*vlan[1-9](\\d){0,3}") || parseCommand.contains("Fa0/1i")
  || parseCommand.contains("Fa0/1o")|| parseCommand.contains("Fa1/0")                               
  || parseCommand.contains("Fa1/1") || parseCommand.contains("Fa1/2")
  || parseCommand.contains("Fa1/3") || parseCommand.contains("Fa1/4")
  || parseCommand.contains("Fa1/5") || parseCommand.contains("Fa1/6")                                    
  || parseCommand.contains("Fa1/7") || parseCommand.contains("Fa1/8") 
  || parseCommand.contains("Fa1/9") || parseCommand.contains("Fa1/11") 
  || parseCommand.contains("Gi0")) {

Even if I try this nothing is found, why?

if(parseCommand.matches(".*vlan.*")

it should be enough vlan[\\d]{1, 4} I think. Can you give a sample command to test against? — Raffaele
– Raffaele, Commented Mar 5, 2013 at 10:59
What kind of command would you like? Any string that contains vlan1 - vlan4094, anything can come before or after — Paul
– Paul, Commented Mar 5, 2013 at 11:00
I could be missing something. But I'm not sure you should have those periods in the regex? — Memento Mori
– Memento Mori, Commented Mar 5, 2013 at 11:01
The regexp looks fine as "vlan1".matches(".*vlan[1-9](\\d){0,3}") returns true. Are you sure that parseCommand contains "vlan1" ? — obourgain
– obourgain, Commented Mar 5, 2013 at 11:02
I am sure because parseCommand.contains("vlan1") works fine. I tried both with and without @MementoMori, neither worked, will try again. Nothing was found with vlan[\\d]{1, 4} method, perhaps it needs .* — Paul
– Paul, Commented Mar 5, 2013 at 11:07

Joop Eggen · Accepted Answer · 2013-03-05 11:12:51Z

1

Use .matches("(?s).*vlan.*") or so for new line characters being catched by .; See DOTALL.

answered Mar 5, 2013 at 11:12

Joop Eggen

110k8 gold badges89 silver badges142 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Paul Over a year ago

This works thanks, I'm not sire why the other answers were not working?

Joop Eggen Over a year ago

You then had a newline character \n in the string and that is not matched by .. The command (?s) also matches \n for dot.

Paul Over a year ago

I see, and would that newline have to come directly before or after vlan to be affecting it, or would a newline anywhere in the string matter?

Joop Eggen Over a year ago

Without (?s) either the first .* does not match (if newline before "vlan", or the second .* if newline after "vlan". By the way, \r is matched by (?s) DOTALL too.

Collectives™ on Stack Overflow

Checking string, regex issue?

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related